Post sg UI fixes #501
Merged
Post sg UI fixes #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## fix-mismatched-sample-count #501 +/- ##
============================================================
Coverage 71.64% 71.64%
============================================================
Files 90 90
Lines 7686 7686
============================================================
Hits 5507 5507
Misses 2179 2179 ☔ View full report in Codecov by Sentry. |
illusional
approved these changes
Jun 28, 2023
danielreti
added a commit
that referenced
this pull request
Jun 29, 2023
* fixed API turning all smaples as true and fixed project grid showing all samples not just active ones * linting * moved active check * moved active type conversion to sample model * Post sg UI fixes (#501) * small fixes to project and analysis grids * Added link to css overflow blogpost
vivbak
added a commit
that referenced
this pull request
Jul 18, 2023
* Fix Mismatched Samples count (#498) * fixed API turning all smaples as true and fixed project grid showing all samples not just active ones * linting * moved active check * moved active type conversion to sample model * Post sg UI fixes (#501) * small fixes to project and analysis grids * Added link to css overflow blogpost * Update backup script to fetch new credentials (#502) * Fix get analysis by id query (#503) * Fix get analysis by ID (+ simplify analysis tests) * Linting * Cohort builder schema (#497) * Cohort builder schema * Fix bad copy-paste * Fix nullable specification * Add internal pid to ParticipantUpsert constructor from ParsedParticipant object (#505) * Add blob.reload() call to cloudhelper get_gcs_blob (#506) * Audit module and test update for SG changes (#509) * Audit module and test update for SG changes * Remove datasets list from audithelper * Typehint fixes for linting * Add project and sample id filter (#511) * Allows uses to filter on sample ID within a project * remove prints * Bump version: 6.0.6 -> 6.1.0 (#512) * Update deploy.yaml (#517) * Update deploy.yaml * Ignore pyenv and dotenv files * update names to kebab-case * add new line to make end-of-file-fixer happy * ignore mypy cache --------- Co-authored-by: daniaki <7043686+daniaki@users.noreply.github.com> --------- Co-authored-by: danielreti <47542969+danielreti@users.noreply.github.com> Co-authored-by: Michael Franklin <michael.franklin@populationgenomics.org.au> Co-authored-by: EddieLF <34049565+EddieLF@users.noreply.github.com> Co-authored-by: daniaki <7043686+daniaki@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes project grid right margin
Fixes summary stats
Fixes analysis runner grid not rendering