Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm: add dm task timezone config #8159

Merged
merged 1 commit into from
Jan 17, 2022
Merged

dm: add dm task timezone config #8159

merged 1 commit into from
Jan 17, 2022

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Jan 14, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@glorv glorv added the area/dm label Jan 14, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 14, 2022
@glorv glorv requested review from hfxsd and lance6716 and removed request for TomShawn January 14, 2022 07:53
@TomShawn
Copy link
Contributor

@glorv 这是 v5.4 生效的配置项吗?

@lance6716
Copy link
Contributor

@glorv 这是 v5.4 生效的配置项吗?

5.3 引入的,文档没更新

pingcap/tiflow#3403

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 14, 2022
@glorv
Copy link
Contributor Author

glorv commented Jan 14, 2022

确实是 5.3 就有的功能,之前遗漏了更新文档了😂

@shichun-0415 shichun-0415 requested review from shichun-0415 and removed request for hfxsd January 17, 2022 02:31
@shichun-0415 shichun-0415 self-assigned this Jan 17, 2022
@shichun-0415 shichun-0415 added needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. translation/doing This PR’s assignee is translating this PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed missing-translation-status This PR does not have translation status info. labels Jan 17, 2022
@shichun-0415
Copy link
Contributor

/verify

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 17, 2022
@hfxsd
Copy link
Collaborator

hfxsd commented Jan 17, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 01c5f8f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 17, 2022
Copy link
Collaborator

@hfxsd hfxsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot merged commit 3755075 into pingcap:master Jan 17, 2022
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jan 17, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8171.

@TomShawn TomShawn removed the needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. label Jan 17, 2022
@glorv glorv deleted the timezone branch January 17, 2022 03:16
@TomShawn
Copy link
Contributor

@glorv Only the dev version of docs-cn has the DM documentation (dev). If you want to modify the DM docs (v5.3 or earlier version), please create a PR in https://github.com/pingcap/docs-dm/tree/release-5.3. Thanks~

@shichun-0415
Copy link
Contributor

@glorv Only the dev version of docs-cn has the DM documentation (dev). If you want to modify the DM docs (v5.3 or earlier version), please create a PR in https://github.com/pingcap/docs-dm/tree/release-5.3. Thanks~

Have told glorv. He will create the PR in docs-dm 5.3. Thanks Tom for reminding.

@TomShawn TomShawn added the v5.4 This PR/issue applies to TiDB v5.4. label Jan 19, 2022
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v5.4 This PR/issue applies to TiDB v5.4.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants