Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: add back time_zone config and change default time_zone to downstream timezone #3403

Merged
merged 15 commits into from
Nov 11, 2021
Merged

dm: add back time_zone config and change default time_zone to downstream timezone #3403

merged 15 commits into from
Nov 11, 2021

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Nov 11, 2021 •
edited
Loading

Cherry-pick #3253 to release-5.3

also cherry-pick #3365 #3376 #3388 to fix unstable tests.

What problem does this PR solve?

Related PR in DM repo: pingcap/dm#2217

close #3378

What is changed and how it works?

  • Change the default time_zone setting from UTC to the global time_zone setting from target db.
  • Add back the time_zone in TaskConfig because this is useful in some special cases.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

Related changes

Release note 

Change default time_zone to downstream timezone

@glorv glorv added area/dm Issues or PRs related to DM. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR. labels Nov 11, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 11, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 11, 2021
@glorv
Copy link
Contributor Author

glorv commented Nov 11, 2021

/run-all-tests

@Ehco1996
Copy link
Contributor

/run-dm-integration-tests
/run-kafka-integration-test

@glorv
Copy link
Contributor Author

glorv commented Nov 11, 2021

/run-dm-integration-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 11, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 11, 2021
@glorv
Copy link
Contributor Author

glorv commented Nov 11, 2021

/run-all-tests

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 11, 2021
@glorv
Copy link
Contributor Author

glorv commented Nov 11, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2bf7050

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2021
@glorv
Copy link
Contributor Author

glorv commented Nov 11, 2021

/run-all-tests

@glorv
Copy link
Contributor Author

glorv commented Nov 11, 2021

/run-all-tests

@glorv
Copy link
Contributor Author

glorv commented Nov 11, 2021

/run-all-tests

@glorv glorv mentioned this pull request Nov 11, 2021
Closed
@glorv
Copy link
Contributor Author

glorv commented Nov 11, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d11e381

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2021
@glorv
Copy link
Contributor Author

glorv commented Nov 11, 2021

/run-kafka-integration-test

1 similar comment
@glorv
Copy link
Contributor Author

glorv commented Nov 11, 2021

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot merged commit 44f47b1 into pingcap:release-5.3 Nov 11, 2021
@lance6716 lance6716 mentioned this pull request Nov 23, 2021
Closed
@glorv glorv deleted the cp-3253 branch December 28, 2021 11:44
@lance6716 lance6716 mentioned this pull request Jan 14, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@Ehco1996 Ehco1996 Ehco1996 approved these changes

@okJiang okJiang Awaiting requested review from okJiang

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@glorv @ti-chi-bot @Ehco1996 @lance6716 @zhouqiang-cl @D3Hunter