Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust timezone config description #885

Merged
merged 3 commits into from
Jan 21, 2022
Merged

adjust timezone config description #885

merged 3 commits into from
Jan 21, 2022

Conversation

glorv
Copy link

@glorv glorv commented Jan 17, 2022 •
edited by shichun-0415
Loading

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Which DM version(s) do your changes apply to? (Required)

Since December 23, 2021, the TiDB DM documentation in the master branch has been merged to TiDB documentation by #8042 and #7317. To create a PR for TiDB DM versions later than v5.3, either go to TiDB English documentation repository or Chinese documentation repository.

  • v5.3 (TiDB DM 5.3 versions)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Jan 17, 2022
@CLAassistant
Copy link

CLAassistant commented Jan 17, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 17, 2022
@glorv glorv requested a review from lance6716 January 17, 2022 06:12
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 17, 2022
@shichun-0415 shichun-0415 added area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. translation/doing This PR’s assignee is translating this PR. type/enhancement This issue/PR improves documentation usability. and removed missing-translation-status This PR does not have translation status info. labels Jan 17, 2022
@shichun-0415 shichun-0415 self-assigned this Jan 17, 2022
@shichun-0415
Copy link
Contributor

@glorv Please sign the Contributor License Agreement. Thanks.

@glorv @shichun-0415
Update en/task-configuration-file-full.md
f381b5d 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
shichun-0415
shichun-0415 approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hfxsd
hfxsd approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@hfxsd hfxsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hfxsd
Copy link
Contributor

hfxsd commented Jan 21, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d46ab06

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 21, 2022
@ti-chi-bot ti-chi-bot merged commit cb74bc3 into pingcap:release-5.3 Jan 21, 2022
@shichun-0415 shichun-0415 removed their assignment Jan 23, 2022
@shichun-0415 shichun-0415 added translation/done This PR has been translated. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@lance6716 lance6716 lance6716 approved these changes

@hfxsd hfxsd hfxsd approved these changes

Assignees
No one assigned
Labels
area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated. type/enhancement This issue/PR improves documentation usability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@glorv @ti-chi-bot @CLAassistant @shichun-0415 @hfxsd @lance6716