Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use golangci-lint on tests #5109

Closed
Tracked by #5058
faddat opened this issue May 7, 2023 · 1 comment
Closed
Tracked by #5058

use golangci-lint on tests #5109

faddat opened this issue May 7, 2023 · 1 comment

Comments

@faddat
Copy link
Member

faddat commented May 7, 2023

The way I found #5060 was to use golangc-ilint on tests.

The following PR's are relevant to this:

I'm trying to keep the PR's as small and easy to review as possible, please lmk how I'm doing with that!

The final boss of this issue is this PR:

In order to close this issue, we'll need to open an issue to update the querygen code...

goal

have greater consistency throughout the codebase and make dev tooling more immediately useful (eg: highlighting)

@faddat
Copy link
Member Author

faddat commented May 12, 2023

Final boss accompished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants