style: lint stableswap the same as the rest of osmosis #5105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:x/gamm
faddat
added
V:state/compatible/backport
czarcas7ic
approved these changes
May 7, 2023
mergify bot
pushed a commit
that referenced
this pull request
May 7, 2023
* sync * lint stableswap in the same manner as any other component of Osmosis * add changelog entry (cherry picked from commit c1c96f4) # Conflicts: # CHANGELOG.md # go.sum # tests/cl-go-client/go.mod # tests/cl-go-client/go.sum
faddat
added a commit
that referenced
this pull request
May 9, 2023
* sync * lint stableswap in the same manner as any other component of Osmosis * add changelog entry
pysel
pushed a commit
that referenced
this pull request
Jun 6, 2023
* sync * lint stableswap in the same manner as any other component of Osmosis * add changelog entry
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR applies the same linting standards to x/stableswap as are applied to the rest of Osmosis overall.
Brief Changelog
There was a good deal of code in the "main functions" that was only being used for tests. This PR moves that code into the tests, so that there's no longer warnings about it being unused.
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? yes