Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run make format #5103

Merged
merged 7 commits into from
May 8, 2023
Merged

chore: run make format #5103

merged 7 commits into from
May 8, 2023

Conversation

faddat
Copy link
Member

@faddat faddat commented May 7, 2023

What is the purpose of the change

This PR runs make format in order to reduce future changesets from similar tasks.

Brief Changelog

  • make format

Testing and Verifying

This change ONLY changes formatting

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? not applicable

@github-actions github-actions bot added C:app-wiring Changes to the app folder C:CLI C:simulator Edits simulator or simulations C:x/concentrated-liquidity C:x/epochs C:x/gamm Changes, features and bugs related to the gamm module. C:x/incentives C:x/lockup C:x/pool-incentives C:x/poolmanager C:x/superfluid C:x/twap Changes to the twap module labels May 7, 2023
@faddat faddat added the V:state/compatible/no_backport State machine compatible PR, depends on prior breaks label May 7, 2023
@faddat faddat marked this pull request as ready for review May 7, 2023 02:13
@faddat faddat marked this pull request as draft May 7, 2023 04:49
@faddat
Copy link
Member Author

faddat commented May 7, 2023

just fixing up the generated code ci error. Whomever has been doing CI is on fire.

@faddat faddat marked this pull request as ready for review May 7, 2023 05:39
@@ -52,6 +52,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Misc Improvements

* [#5103](https://github.com/osmosis-labs/osmosis/pull/5103) Run `make format`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's only put changes in the changelog that clients would like to know about. e.g. API breaks, bug fixes etc

Suggested change
* [#5103](https://github.com/osmosis-labs/osmosis/pull/5103) Run `make format`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't block merge. Will update the changelog pre-release

@p0mvn p0mvn merged commit 7cc0090 into main May 8, 2023
@p0mvn p0mvn deleted the faddat/run-make-format branch May 8, 2023 13:13
pysel added a commit that referenced this pull request Jun 6, 2023
* this pr only runs make format

* run make format

* correct comment for PoolsKey

* restore grpc_query.go to same style as found in main

* correct changelog formatting

---------

Co-authored-by: Ruslan Akhtariev <46343690+pysel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:app-wiring Changes to the app folder C:CLI C:simulator Edits simulator or simulations C:x/concentrated-liquidity C:x/epochs C:x/gamm Changes, features and bugs related to the gamm module. C:x/incentives C:x/lockup C:x/pool-incentives C:x/poolmanager C:x/superfluid C:x/twap Changes to the twap module V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants