style: address forced type assertions in tests #5116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faddat
requested review from
nicolaslara,
p0mvn,
czarcas7ic and
mattverse
as code owners
github-actions
bot
added
C:app-wiring
faddat
changed the title
faddat
added
no-changelog
V:state/compatible/no_backport
Co-authored-by: Ruslan Akhtariev <46343690+pysel@users.noreply.github.com>
Co-authored-by: Ruslan Akhtariev <46343690+pysel@users.noreply.github.com>
|
Thanks for the review @pysel :) |
Co-authored-by: Roman <roman@osmosis.team>
Co-authored-by: Roman <roman@osmosis.team>
Co-authored-by: Roman <roman@osmosis.team>
nicolaslara
reviewed
May 9, 2023
| @@ -1056,12 +1056,34 @@ func (s *IntegrationTestSuite) TestIBCWasmHooks() { | |||
| var response map[string]interface{} | |||
| s.Require().Eventually(func() bool { | |||
| response, err = nodeA.QueryWasmSmartObject(contractAddr, fmt.Sprintf(`{"get_total_funds": {"addr": "%s"}}`, senderBech32)) | |||
| totalFunds := response["total_funds"].([]interface{})[0] | |||
| amount := totalFunds.(map[string]interface{})["amount"].(string) | |||
| denom := totalFunds.(map[string]interface{})["denom"].(string) | |||
There was a problem hiding this comment.
I find the old versions much more readable here (since it's just a test). I'm not strongly against the type assertion checks and get the point in chain code, but in tests I tend to favor making the test shorted since robustness doesn't matter.
For json in particular, we may want to use https://github.com/tidwall/gjson
nicolaslara
approved these changes
May 9, 2023
|
@nicolaslara is it okay if I try to get your style preference into the final PR for #5061 ? makes sense to me actually |
|
sounds good! :) |
czarcas7ic
approved these changes
May 10, 2023
pysel
added a commit
that referenced
this pull request
Jun 6, 2023
* fix forced type assertions * revert change to linter config * Update tests/e2e/e2e_test.go Co-authored-by: Ruslan Akhtariev <46343690+pysel@users.noreply.github.com> * Update x/concentrated-liquidity/pool_test.go Co-authored-by: Ruslan Akhtariev <46343690+pysel@users.noreply.github.com> * skip pool = poolI * update swap_test.go to test that cl type assertions fail * trial * we needed pool because it's used to CalcInGivenOut * Update x/concentrated-liquidity/pool_test.go Co-authored-by: Roman <roman@osmosis.team> * Update x/concentrated-liquidity/pool_test.go Co-authored-by: Roman <roman@osmosis.team> * Update x/gamm/keeper/swap_test.go Co-authored-by: Roman <roman@osmosis.team> --------- Co-authored-by: Ruslan Akhtariev <46343690+pysel@users.noreply.github.com> Co-authored-by: Roman <roman@osmosis.team>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Changelog
This PR addresses forced type assertions in the Osmosis test suite.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no