Make the generated report use the correct background color #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: * Remove font and color overrides from generated reports * Remove side-nav from the exported report * Avoid creating a footer when it has no content * Fix report dimensions Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
2 tasks
|
For UX review completions sake - do you have an export in Next Light as well? |
I added a sample to the PR description. |
Swiddis
approved these changes
Aug 31, 2023
YANG-DB
approved these changes
Aug 31, 2023
rupal-bq
approved these changes
Aug 31, 2023
|
@AMoo-Miki thanks for the additional export for light mode. LGTM! |
derek-ho
approved these changes
Aug 31, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
Also: * Remove font and color overrides from generated reports * Remove side-nav from the exported report * Avoid creating a footer when it has no content * Fix report dimensions Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit 13288ec) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho
pushed a commit
that referenced
this pull request
Sep 5, 2023
Also: * Remove font and color overrides from generated reports * Remove side-nav from the exported report * Avoid creating a footer when it has no content * Fix report dimensions (cherry picked from commit 13288ec) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
Was there any consideration of using print mode so that pdfs would be printable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the generated report use the correct background color
Also:
test12_2023-08-10T05 49 37.983Z_b12ad400-3741-11ee-a3da-f9dc44b8dbe5.pdf
Test23_2023-08-30T20 18 35.215Z_65a3edf0-4772-11ee-bd7a-cb1f0be60683.pdf
Issues Resolved
Fixes #111
Fixes opensearch-project/OpenSearch-Dashboards#3979
opensearch-project/reporting#735 - Part 1
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.