[Look&Feel] Discover and Query Management fix

[danieldong51]

Description

This PR fixes 4 things:

• For the Saved Query Management Button:
  • Reverts Saved Query Management button to have a default browser tooltip rather than OuiTooltip, which fixes an alignment issue
  • Removes the downArrow icon from Saved Query Management button, which was erroneously added back in [Look&Feel] Replace browser tooltip usage with OUI tooltip #7231
• For the Discover Sidebar:
  • Changes Discover sidebar add and remove field icons from EuiSmallButtonIcon to EuiButtonIcon with size='xs', which fixes the spacing issue in the sidebar
• For the Visualization Legend Button:
  • Change positioning attributes on Visualization Legend Button from the button to the tooltip anchor, to fix a bug where the tooltip was separated from the button.

Screenshot

Saved Query Management Button

Note the change in alignment of the saved query management icon.

Scope	Before (v7Light)	After (v7Light)	Before (v8dark)	After (v8dark)
Discover, query enhancements off
Discover, query enhancements on
Dashboards

Discover: Sidebar

Note the change in spacing of the list items in the sidebar.

Before (v7Light)	After (v7Light)	Before (v8dark)	After (v8dark)

Toggle Legend

Note the change in location of the tooltip.

Scope	Before (v8dark)	After (v8dark)
Dashboards
Visualization Page

Changelog

• refactor: [Look&Feel] Discover and Query Management fix

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[github-actions]

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.65%. Comparing base (2d8c743) to head (761a7d2).
Report is 245 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7530      +/-   ##
==========================================
- Coverage   63.65%   63.65%   -0.01%     
==========================================
  Files        3629     3629              
  Lines       79519    79519              
  Branches    12602    12602              
==========================================
- Hits        50618    50616       -2     
- Misses      25834    25835       +1     
- Partials     3067     3068       +1     

Flag	Coverage Δ
Linux_1	30.76% <ø> (ø)
Linux_2	55.58% <ø> (ø)
Linux_3	40.24% <100.00%> (+<0.01%)	⬆️
Linux_4	31.57% <ø> (ø)
Windows_1	30.78% <ø> (ø)
Windows_2	55.53% <ø> (ø)
Windows_3	40.24% <100.00%> (ø)
Windows_4	31.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[virajsanghvi]

LGTM - test failures appear to be due to flakey tests

[opensearch-trigger-bot]

The backport to 2.16 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.16
# Create a new branch
git switch --create backport/backport-7530-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 70739998513017bb3e4d808bf30da9258a3e87a9
# Push it to GitHub
git push --set-upstream origin backport/backport-7530-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.16

Then, create a pull request where the base branch is 2.16 and the compare/head branch is backport/backport-7530-to-2.16.