Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Look&Feel] Discover and Query Management fix #7558

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7073999 from #7530.

* Removed downArrow icon and tooltip

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Changed icons from smallIcons to xs

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Added browser tooltip back

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Changed remove field icon size to xs

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Changeset file for PR #7530 created/updated

* Changed positioning attributes to ToolTip Anchor

Signed-off-by: Dan Dong <danieldong51@gmail.com>
(cherry picked from commit 5dbce93)

* Updated snapshot testing

Signed-off-by: Dan Dong <danieldong51@gmail.com>

---------

Signed-off-by: Dan Dong <danieldong51@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 7073999)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.76%. Comparing base (7b1f742) to head (62834b9).

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #7558      +/-   ##
==========================================
+ Coverage   63.74%   63.76%   +0.01%     
==========================================
  Files        3628     3628              
  Lines       79498    79498              
  Branches    12590    12590              
==========================================
+ Hits        50676    50688      +12     
+ Misses      25759    25748      -11     
+ Partials     3063     3062       -1     
Flag Coverage Δ
Linux_1 30.77% <ø> (ø)
Linux_2 55.70% <ø> (ø)
Linux_3 40.29% <100.00%> (-0.01%) ⬇️
Linux_4 31.71% <ø> (ø)
Windows_1 30.79% <ø> (?)
Windows_2 55.65% <ø> (ø)
Windows_3 40.29% <100.00%> (ø)
Windows_4 31.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine, retriggered ci to see if we could get them to pass, but failures are unrelated

@virajsanghvi virajsanghvi merged commit ec4ee8d into 2.x Jul 30, 2024
67 of 70 checks passed
@virajsanghvi
Copy link
Collaborator

Merging, one of the Error: expected '' to equal 'memory:>220000' errors resolved, one continued, but transient as its coming up on other PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset look & feel Look and Feel Improvements v2.16.0 valued-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants