Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Look&Feel] Discover and Query Management fix #7530

Merged
merged 7 commits into from
Jul 29, 2024
Merged

[Look&Feel] Discover and Query Management fix #7530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
224336d
Removed downArrow icon and tooltip
danieldong51 Jul 26, 2024
8dcf88a
Changed icons from smallIcons to xs
danieldong51 Jul 26, 2024
5566e91
Added browser tooltip back
danieldong51 Jul 26, 2024
de3c319
Changed remove field icon size to xs
danieldong51 Jul 26, 2024
73946d4
Changeset file for PR #7530 created/updated
opensearch-changeset-bot[bot] Jul 26, 2024
377222b
Changed positioning attributes to ToolTip Anchor
danieldong51 Jul 26, 2024
761a7d2
Updated snapshot testing
danieldong51 Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/7530.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
refactor:
- [Look&Feel] Discover and Query Management fix ([#7530](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7530))
27 changes: 11 additions & 16 deletions ...ic/ui/saved_query_management/__snapshots__/saved_query_management_component.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 9 additions & 11 deletions src/plugins/data/public/ui/saved_query_management/saved_query_management_component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ import {
EuiText,
EuiSpacer,
EuiIcon,
EuiToolTip,
} from '@elastic/eui';

import { i18n } from '@osd/i18n';
Expand Down Expand Up @@ -176,16 +175,15 @@ export function SavedQueryManagementComponent({
});

const savedQueryPopoverButton = (
<EuiToolTip content={label} delay="long" position="bottom">
<EuiSmallButtonEmpty
onClick={handleTogglePopover}
aria-label={label}
data-test-subj="saved-query-management-popover-button"
className="osdSavedQueryManagement__popoverButton"
>
<EuiIcon type="save" className="euiQuickSelectPopover__buttonText" />
</EuiSmallButtonEmpty>
</EuiToolTip>
<EuiSmallButtonEmpty
onClick={handleTogglePopover}
aria-label={label}
data-test-subj="saved-query-management-popover-button"
className="osdSavedQueryManagement__popoverButton"
title={label}
>
<EuiIcon type="save" className="euiQuickSelectPopover__buttonText" />
</EuiSmallButtonEmpty>
);

const savedQueryRows = () => {
Expand Down
7 changes: 4 additions & 3 deletions src/plugins/discover/public/application/components/sidebar/discover_field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ import React, { useState } from 'react';
import {
EuiPopover,
EuiPopoverTitle,
EuiSmallButtonIcon,
EuiButtonIcon,
EuiToolTip,
EuiFlexGroup,
Expand Down Expand Up @@ -153,7 +152,7 @@ export const DiscoverField = ({
defaultMessage: 'Add field as column',
})}
>
<EuiSmallButtonIcon
<EuiButtonIcon
iconType="plusInCircleFilled"
onClick={(ev: React.MouseEvent<HTMLButtonElement>) => {
if (ev.type === 'click') {
Expand All @@ -163,6 +162,7 @@ export const DiscoverField = ({
ev.stopPropagation();
toggleDisplay(field);
}}
size="xs"
data-test-subj={`fieldToggle-${field.name}`}
aria-label={addLabelAria}
className="dscSidebarField__actionButton"
Expand All @@ -177,7 +177,7 @@ export const DiscoverField = ({
defaultMessage: 'Remove field from table',
})}
>
<EuiSmallButtonIcon
<EuiButtonIcon
color="danger"
iconType="cross"
onClick={(ev: React.MouseEvent<HTMLButtonElement>) => {
Expand All @@ -188,6 +188,7 @@ export const DiscoverField = ({
ev.stopPropagation();
toggleDisplay(field);
}}
size="xs"
data-test-subj={`fieldToggle-${field.name}`}
aria-label={removeLabelAria}
className="dscSidebarField__actionButton"
Expand Down
4 changes: 2 additions & 2 deletions ...lugins/vis_type_vislib/public/vislib/components/legend/__snapshots__/legend.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions src/plugins/vis_type_vislib/public/vislib/components/legend/_legend.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ $visLegendLineHeight: $euiSize;

.visLegend__toggle {
border-radius: $euiBorderRadius;
position: absolute;
bottom: 0;
left: 0;
display: flex;
padding: $euiSizeXS;
background-color: $euiColorEmptyShade;
Expand All @@ -24,6 +21,12 @@ $visLegendLineHeight: $euiSize;
}
}

.visLegend__toggleTooltipAnchor {
position: absolute;
bottom: 0;
left: 0;
}

.visLegend__toggle--isOpen {
background-color: transparentize($euiColorDarkestShade, 0.9);
opacity: 1;
Expand Down
7 changes: 6 additions & 1 deletion src/plugins/vis_type_vislib/public/vislib/components/legend/legend.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,12 @@ export class VisLegend extends PureComponent<VisLegendProps, VisLegendState> {

return (
<div className="visLegend">
<EuiToolTip content={label} delay="long" position="bottom">
<EuiToolTip
anchorClassName="visLegend__toggleTooltipAnchor"
content={label}
delay="long"
position="bottom"
>
<button
type="button"
onClick={this.toggleLegend}
Expand Down
Loading