Replace flaky host instrumentation test #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of checking if the underlying system memory does not change over a second, an assumption heavily dependant on the external system, test that the reported memory is within expected bounds.
MrAlias
added
bug
MrAlias
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey and
XSAM
as code owners
Aneurysm9
approved these changes
Oct 28, 2020
XSAM
approved these changes
Oct 29, 2020
vchitai
pushed a commit
to vchitai/opentelemetry-go-contrib
that referenced
this pull request
Nov 13, 2020
Instead of checking if the underlying system memory does not change over a second, an assumption heavily dependant on the external system, test that the reported memory is within expected bounds.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of checking if the underlying system memory does not change over a second, an assumption heavily dependent on the external system, test that the reported memory is within expected bounds.
Part of #425