Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Host TestHostMemory Failure #313

Closed
MrAlias opened this issue Aug 28, 2020 · 2 comments · Fixed by #426
Closed

Investigate Host TestHostMemory Failure #313

MrAlias opened this issue Aug 28, 2020 · 2 comments · Fixed by #426
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone
RC1

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Aug 28, 2020

opentelemetry-go-contrib/instrumentation/host/host_test.go

Lines 182 to 183 in e6529ec

// Check that utilization sums to 1.0:
require.InEpsilon(t, 1.0, hostUsedUtil+hostAvailableUtil, tolerance)

I'm not able to run the tests locally anymore as this test is a constant failure on my local machine, routinely having greater than 10% relative error.

=== RUN   TestHostMemory
    host_test.go:183: 
        	Error Trace:	host_test.go:183
        	Error:      	Relative error is too high: 0.05 (expected)
        	            	        < 0.10391638662049218 (actual)
        	Test:       	TestHostMemory
--- FAIL: TestHostMemory (1.20s)

It also periodically fails on the CI system as well, i.e. https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-go-contrib/822/workflows/9d9be7e4-4318-4851-adaf-13af791e233b/jobs/1479

We should look into redesigning this test or tuning the tolerances a bit.
@MrAlias MrAlias added bug Something isn't working help wanted Extra attention is needed labels Aug 28, 2020
@MrAlias
Copy link
Contributor Author

MrAlias commented Aug 28, 2020

It looks like it might also be correlated with 386 architecture tests. This is conjecture at this point though.

@MrAlias MrAlias added this to the RC1 milestone Sep 3, 2020
@MrAlias
Copy link
Contributor Author

MrAlias commented Nov 5, 2020

Duplicated by #425

@MrAlias MrAlias closed this as completed Nov 5, 2020
@MrAlias MrAlias linked a pull request Nov 5, 2020 that will close this issue
Replace flaky host instrumentation test #426
Merged
plantfansam referenced this issue in plantfansam/opentelemetry-go-contrib Mar 18, 2022
@lizthegrey @rghetia
propose additional CODEOWNERS (#313)
f403198 
* propose additional CODEOWNERS

* remove freeformz from approver nomination

* no partial ownership
plantfansam referenced this issue in plantfansam/opentelemetry-go-contrib Mar 18, 2022
@lizthegrey
finish adding krnowak to approvers (#445)
7200bb9 
- [x] >10 substantive contributions
- [x] Active >1mo
- [x] add to `CODEOWNERS` (done already in #313)
- [x] Maintainer nomination (done already in #313)
- [ ] Add to @open-telemetry/go-approvers 
- [x] Add to `CONTRIBUTING.md` (done in this pull)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
RC1
Development

Successfully merging a pull request may close this issue.

Replace flaky host instrumentation test MrAlias/opentelemetry-go-contrib
1 participant
@MrAlias