Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace flaky host instrumentation test #426

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Replace flaky host instrumentation test #426

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6337d20
Replace flaky host instrumentation test
MrAlias Oct 28, 2020
eb3a448
Merge branch 'master' into host-testing
MrAlias Oct 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 16 additions & 30 deletions instrumentation/host/host_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ package host_test
import (
"context"
"os"
"runtime"
"testing"
"time"

Expand Down Expand Up @@ -142,45 +141,32 @@ func TestHostMemory(t *testing.T) {
assert.NoError(t, err)

ctx := context.Background()
hostBefore, err := mem.VirtualMemoryWithContext(ctx)
vMem, err := mem.VirtualMemoryWithContext(ctx)
require.NoError(t, err)

slice := make([]byte, 100*1024*1024)
defer runtime.KeepAlive(slice)
for i := range slice {
slice[i] = byte(i)
}

// As we are going to read the /proc file system for this info, sleep a while:
time.Sleep(time.Second)

impl.RunAsyncInstruments()

hostAfter, err := mem.VirtualMemoryWithContext(ctx)
require.NoError(t, err)

hostUsed := getMetric(impl, "system.memory.usage", host.LabelMemoryUsed[0])
assert.Greater(t, hostUsed, 0.0)
assert.LessOrEqual(t, hostUsed, float64(vMem.Total))

hostAvailable := getMetric(impl, "system.memory.usage", host.LabelMemoryAvailable[0])
assert.GreaterOrEqual(t, hostAvailable, 0.0)
assert.Less(t, hostAvailable, float64(vMem.Total))

hostUsedUtil := getMetric(impl, "system.memory.utilization", host.LabelMemoryUsed[0])
hostAvailableUtil := getMetric(impl, "system.memory.utilization", host.LabelMemoryAvailable[0])

beforeTotal := hostBefore.Available + hostBefore.Used
afterTotal := hostAfter.Available + hostAfter.Used
measureTotal := hostUsed + hostAvailable

// Tolerance is 5%
const tolerance = 0.05
assert.Greater(t, hostUsedUtil, 0.0)
assert.LessOrEqual(t, hostUsedUtil, 1.0)

// Check that the sum of used and available doesn't change:
require.InEpsilon(t, float64(beforeTotal), measureTotal, tolerance)
require.InEpsilon(t, float64(afterTotal), measureTotal, tolerance)

// Check that the implied total is equal from both Used and Available metrics:
require.InEpsilon(t, hostUsed/hostUsedUtil, hostAvailable/hostAvailableUtil, tolerance)
hostAvailableUtil := getMetric(impl, "system.memory.utilization", host.LabelMemoryAvailable[0])
assert.GreaterOrEqual(t, hostAvailableUtil, 0.0)
assert.Less(t, hostAvailableUtil, 1.0)

// Check that utilization sums to 1.0:
require.InEpsilon(t, 1.0, hostUsedUtil+hostAvailableUtil, tolerance)
if hostUsed > hostAvailable {
assert.Greater(t, hostUsedUtil, hostAvailableUtil)
} else {
assert.Less(t, hostUsedUtil, hostAvailableUtil)
}
}

func sendBytes(t *testing.T, count int) error {
Expand Down