Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change subject Area to use the OMRS generic handlers #5399

Closed
davidradl opened this issue Jun 30, 2021 · 4 comments
Closed

Change subject Area to use the OMRS generic handlers #5399

davidradl opened this issue Jun 30, 2021 · 4 comments
Assignees

Comments

@davidradl
Copy link
Member

No description provided.

@davidradl davidradl self-assigned this Jun 30, 2021
@davidradl
Copy link
Member Author

I am considering moving over to use the generic handlers for the Subject Area, as I was looking to extend to re use code in in the generic handlers for this fix. I then pickup the anchor classifications and visibility logic. Also the jsonld parser will now create these classifications when using the subject area OMAS API

My proposal is that :

I change the code to call GlossaryHandler GlossaryBuilder GlossaryCategoryBuilder GlossaryCategoryHandler GlossaryTermBuilder and GlossaryTermHandler. This would work for add, update, read, find
I then need to amend my mappers to map the beans to the OMAS
I still need logic could deletes and replace/update in the omas code. I want to reject delete requests of glossaries with content.
Additional handler content

I need to extend the omrs handler to include get/find category terms , category children, glossary terms, glossary categories and terms categorizations. All with filters and regex flags.
I need to consider what this means for the relationship APIs
I need to consider what this means for the graph API. getEntityNeighbourhood.
@mandy-chessell @cmgrote @planetf1 does this sound right or have I misunderstood / missed something?

@davidradl
Copy link
Member Author

davidradl commented Jun 30, 2021

I am thinking that I may not need to redo the existing subject area generics and could go straight to the omrs generics helper.

davidradl added a commit to davidradl/egeria that referenced this issue Jun 30, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jun 30, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 1, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 1, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 1, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 1, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 1, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 1, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 1, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 1, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 1, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 1, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 1, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 2, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 2, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 5, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 5, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 5, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
Copy link
Member Author

davidradl commented Jul 5, 2021

I have initial implementations for add , update, delete and get for each of the nodes.

  • for restore, there are no generic handler methods I could find. I am thinking it should as much as possible try to undo what the delete did.

Nodes
- if the restore is for a Term or Category only restore if the glossary is active - otherwise error.
- if the restore is for a Term or Category that is itself an anchor -for example if it has comments. Then the anchored content should be restored.
- For directly connected deleted, non anchored relationships to active entities. For example if there was a has-a relationship to a parent term, it seems reasonable I restore this.
- restore should update the latestChange like update does
- restore should restore all associated deleted classifications (which may be more that were there at delete time).
- restore should add in spine object classifications and anchor and latestchange classifications as appropriate
- if the restore is for a glossary then we should restore
- any deleted classifications, and deleted relationships to active entities
- any deleted anchored content including any deleted classifications, and deleted relationships to active entities

Relationships
Only restore if both ends are active.

  • for a deletion of a has-a relationship - I am thinking we should remove the spine attribute and optionally the spine object (if it is the last has-a) and then the restore should put them back.

@mandy-chessell @cmgrote @planetf1 @lpalashevski Let me know if there is existing logic or your thoughts on this .

** Update after community meeting on 6th of July **
This issue will implement a minimal restore. #5465 implements new more sophisticated restore logic in the generic handlers.

davidradl added a commit to davidradl/egeria that referenced this issue Jul 5, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 6, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
bogdan-sava pushed a commit to bogdan-sava/egeria that referenced this issue Jul 7, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
Signed-off-by: Bogdan Sava <bogdan.sava@gmail.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 7, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 7, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 7, 2021
…eric handler

Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 8, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 12, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 13, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 13, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 16, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 16, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 19, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 20, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 20, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 21, 2021
…gory

Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 21, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 21, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 22, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 22, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 22, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 22, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 26, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 26, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 26, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 26, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 26, 2021
…elationship tests

Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
Copy link
Member Author

Updated #5465 to include the cponsideration of restores around TermAnchors, which delete the Term.

davidradl added a commit to davidradl/egeria that referenced this issue Jul 26, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 27, 2021
…ests

Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 27, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 30, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jul 31, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Aug 3, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit that referenced this issue Aug 3, 2021
#5399 generic handlers for subject Area
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant