Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subject Area OMAS paging error #5388

Closed
davidradl opened this issue Jun 24, 2021 · 5 comments
Closed

Subject Area OMAS paging error #5388

davidradl opened this issue Jun 24, 2021 · 5 comments
Assignees

Comments

@davidradl
Copy link
Member

davidradl commented Jun 24, 2021

If you define 8 categories and then use a page size of 5 and get the first then the second page, you see 5 categories on the first page and 3 on the second page. One category is duplicated on each page and one is not shown. If you put the pageSize to 10 then you see all 8 categories.

I think this has gone unnoticed because the FVT only checks the number not that the results are correct.

@davidradl davidradl self-assigned this Jun 24, 2021
davidradl added a commit to davidradl/egeria that referenced this issue Jun 25, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
Copy link
Member Author

I am adding FVT tests to get them to fail. I will use this to decide whether I need to put ordering parameter on every call to be sure of the order. Initially I want to confirm that this is due to bad logic in the OMAS code and not in a lower layer.

I notice the FVTs still submitted .* and that the client library and the FVT wrapper had incorrect logic in around the setting of exactValue and mixed case. I am fixing these bugs in this issue as well.

@davidradl
Copy link
Member Author

I am fixing #5390 separately from this issue

davidradl added a commit to davidradl/egeria that referenced this issue Jun 25, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jun 25, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
Copy link
Member Author

davidradl commented Jun 25, 2021

Added more FVTs and have exposed some bugs, where .* was being used and is no longer supported , also the exactValue and ignoreCase flags were not being passed through appropriately in some cases.

@davidradl
Copy link
Member Author

I have found the error in subject area OMAS, the startingFrom should is working off the unfiltered list ; it should work off the filtered list (i.e. search results after the searchCriteria have been applied).

davidradl added a commit to davidradl/egeria that referenced this issue Jun 26, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
davidradl added a commit to davidradl/egeria that referenced this issue Jun 30, 2021
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
Copy link
Member Author

I am fixing this properly and more completely in #5399

davidradl added a commit that referenced this issue Jun 30, 2021
#5388 add FVTs to show the paging issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant