Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Audit logging on purge #5474

Closed
davidradl opened this issue Jul 8, 2021 · 4 comments
Closed

Inconsistent Audit logging on purge #5474

davidradl opened this issue Jul 8, 2021 · 4 comments
Assignees
Labels
good first issue Good for newcomers no-issue-activity Issues automatically marked as stale because they have not had recent activity.

Comments

@davidradl
Copy link
Member

In the repository handler

  • removeEntity tries to delete then if delete is not supported issues a purge, the purge method issues an audit log
  • There are 2 callers to purgeRelationship only one of which audit logs

This is inconsistent.
I suggest we move the relationship audit log to the purge method, which means that both callers will audit log.

@davidradl davidradl added the good first issue Good for newcomers label Jul 8, 2021
@mandy-chessell
Copy link
Contributor

To make this a good first issue, you need to add details of where this code is and how to test it. Also what should appear on the audit log - for example if purge is called from the API then you would want a different audit message to the case where purge is being used instead of delete.

@davidradl
Copy link
Member Author

Thanks @mandy-chessell I will update after #5399 is complete -as it simplifies what we need to change

@planetf1
Copy link
Member

(assigning for clarification)

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the no-issue-activity Issues automatically marked as stale because they have not had recent activity. label Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers no-issue-activity Issues automatically marked as stale because they have not had recent activity.
Projects
None yet
Development

No branches or pull requests

3 participants