Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile_commands.json for MSVC #238

Merged
merged 3 commits into from
Mar 30, 2024
Merged

Fix compile_commands.json for MSVC #238

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f9bb3b
fix: compile_commands.json for MSVC
segevfiner Mar 30, 2024
20cb283
Review fix
segevfiner Mar 30, 2024
bb6b775
Update pylib/gyp/generator/compile_commands_json.py
segevfiner Mar 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pylib/gyp/generator/compile_commands_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,8 @@ def GenerateOutput(target_list, target_dicts, data, params):
AddCommandsForTarget(cwd, target, params, per_config_commands)

try:
output_dir = params["options"].generator_output
# generator_output can be `None` on Windows machines
output_dir = params["options"].generator_output or os.getcwd()
anonrig marked this conversation as resolved.
Show resolved Hide resolved
except (AttributeError, KeyError):
output_dir = params["generator_flags"].get("output_dir", "out")
for configuration_name, commands in per_config_commands.items():
Expand Down