Fix compile_commands.json for MSVC #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segevfiner
added a commit
to segevfiner/node
that referenced
this pull request
Mar 30, 2024
…a vcbuild.bat This also needs nodejs/gyp-next#238
anonrig
reviewed
Mar 30, 2024
generator_output is None when trying to use that in Node.js via vcbuild.bat
segevfiner
force-pushed
the
fix-compile-commands-msvc
branch
from
635a464
to
9f9bb3b
Compare
segevfiner
added a commit
to segevfiner/node
that referenced
this pull request
Mar 30, 2024
…a vcbuild.bat This also needs nodejs/gyp-next#238
anonrig
reviewed
Mar 30, 2024
Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
anonrig
approved these changes
Mar 30, 2024
cclauss
approved these changes
Mar 30, 2024
segevfiner
added a commit
to segevfiner/gyp-next
that referenced
this pull request
Apr 1, 2024
cclauss
added a commit
that referenced
this pull request
Apr 2, 2024
…ne (#239) * Fix compile_commands.json output location when generator_output is None Followup to #238 * Fix lint * Update pylib/gyp/generator/compile_commands_json.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update pylib/gyp/generator/compile_commands_json.py Co-authored-by: Christian Clauss <cclauss@me.com> --------- Co-authored-by: Christian Clauss <cclauss@me.com>
segevfiner
added a commit
to segevfiner/node
that referenced
this pull request
May 27, 2024
…a vcbuild.bat This also needs nodejs/gyp-next#238
segevfiner
added a commit
to segevfiner/node
that referenced
this pull request
May 27, 2024
aduh95
pushed a commit
to segevfiner/node
that referenced
this pull request
Sep 6, 2024
jasnell
pushed a commit
to nodejs/node
that referenced
this pull request
Sep 21, 2024
Refs: nodejs/gyp-next#238 PR-URL: #52279 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generator_outputisNonewhen trying to use that in Node.js viavcbuild.bat