Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile_commands.json for MSVC #238

Merged
merged 3 commits into from
Mar 30, 2024
Merged

Fix compile_commands.json for MSVC #238

merged 3 commits into from
Mar 30, 2024

Commits on Mar 30, 2024

  1. fix: compile_commands.json for MSVC 

    generator_output is None when trying to use that in Node.js via vcbuild.bat
    @segevfiner
    segevfiner committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    9f9bb3b View commit details
    Browse the repository at this point in the history

  2. Review fix

    @segevfiner
    segevfiner committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    20cb283 View commit details
    Browse the repository at this point in the history

  3. Update pylib/gyp/generator/compile_commands_json.py 

    Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
    @segevfiner @anonrig
    segevfiner and anonrig committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    bb6b775 View commit details
    Browse the repository at this point in the history