Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nf-prov #2455

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Add nf-prov #2455

wants to merge 7 commits into from

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels
Copy link
Member

ewels commented Sep 29, 2023

Good, though I wonder if it's worth trialling in a pipeline or two for a while before merging into the template? Just because the plugin is very new and not super well tested yet.

Could arguably do this alongside merging to the template I guess, so maybe no need to hold this up.

Co-authored-by: Phil Ewels <phil.ewels@seqera.io>
@maxulysse
Copy link
Member Author

Good, though I wonder if it's worth trialling in a pipeline or two for a while before merging into the template? Just because the plugin is very new and not super well tested yet.

Could arguably do this alongside merging to the template I guess, so maybe no need to hold this up.

I can test in Sarek

@maxulysse
Copy link
Member Author

Good, though I wonder if it's worth trialling in a pipeline or two for a while before merging into the template? Just because the plugin is very new and not super well tested yet.
Could arguably do this alongside merging to the template I guess, so maybe no need to hold this up.

I can test in Sarek

nf-core/sarek#1259

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e5013b) 75.06% compared to head (1fa4aed) 70.62%.
Report is 5 commits behind head on dev.

❗ Current head 1fa4aed differs from pull request most recent head 79f3c58. Consider uploading reports for the commit 79f3c58 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2455      +/-   ##
==========================================
- Coverage   75.06%   70.62%   -4.45%     
==========================================
  Files          85       88       +3     
  Lines        9376     9493     +117     
==========================================
- Hits         7038     6704     -334     
- Misses       2338     2789     +451     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfy133
Copy link
Member

jfy133 commented Sep 29, 2023

Works in taxprofiler 👍

@maxulysse maxulysse mentioned this pull request Sep 29, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants