Add nf-prov #1259
Merged
Add nf-prov #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
should we test it a bit first before adding to the patch release? |
adamrtalbot
reviewed
Sep 29, 2023
| @@ -328,6 +329,10 @@ dag { | |||
| enabled = true | |||
| file = "${params.outdir}/pipeline_info/pipeline_dag_${trace_timestamp}.html" | |||
| } | |||
| prov { | |||
| enabled = true | |||
| file = "${params.outdir}/pipeline_info/manifest_${trace_timestamp}.bco.json" | |||
There was a problem hiding this comment.
Why manifest_${trace_timestamp}.bco.json? What does that mean?
There was a problem hiding this comment.
.bco because BCO format
There was a problem hiding this comment.
Bitstream Compressed Outline Font file?
There was a problem hiding this comment.
Ah biocompute object. That's not obvious, let's add some documentation.
I'm not a fan of generic names like manifest_*_bco.json, I'd prefer it to be ${workflow.sessionId}.bco.json but that feels like a separate issue.
There was a problem hiding this comment.
comment on nf-core/tools#2455
adamrtalbot
reviewed
Sep 29, 2023
| @@ -328,6 +329,10 @@ dag { | |||
| enabled = true | |||
| file = "${params.outdir}/pipeline_info/pipeline_dag_${trace_timestamp}.html" | |||
| } | |||
| prov { | |||
| enabled = true | |||
There was a problem hiding this comment.
Could add a parameter for disabling it here? params.provenance?
There was a problem hiding this comment.
That's what I said to @ewels and he said, you'd just need to add
prov.enabled = false in a config file to disable, so no need for a params.
And I kind of agreed because that's what we do with the other reports
There was a problem hiding this comment.
that's fair enough. I believe --prov.enabled false might work as well?
There was a problem hiding this comment.
I'd say no, prov is a nextflow thingy, so -prov false maybe?
It's been tested already ;-) |
@jfy133 reports that it works in taxprofiler: nf-core/tools#2455 (comment) |
|
ok fine. Just didn't want to break the patch :D |
FriederikeHanssen
approved these changes
Sep 29, 2023
We can discuss that in the prepare release PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).