Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default registry to quay.io #3344

Merged
merged 21 commits into from
May 2, 2023
Merged

Default registry to quay.io #3344

merged 21 commits into from
May 2, 2023

Conversation

adamrtalbot
Copy link
Contributor

Sets the default Docker registry to quay.io.

Where necessary, specifies full URI for every Docker container that gets pulled from docker.io.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@adamrtalbot
Add default registry for Docker and Podman to quay.io
a189d60 
Will break any non quay.io containers that were not specified with a
full URI
@adamrtalbot
Use full URI for all modules
3f4f0cb
@maxulysse
Copy link
Member

only 19 file changed?

@adamrtalbot
Copy link
Contributor Author

only 19 file changed?

This just adds docker.io to existing modules. Every module is specified with a full URI now.

If you know of any more let me know and I'll update.

@maxulysse
Copy link
Member

only 19 file changed?

This just adds docker.io to existing modules. Every module is specified with a full URI now.

If you know of any more let me know and I'll update.

Oh, yeah, so full retro-compatibility should be fairly possible

@adamrtalbot
Copy link
Contributor Author

only 19 file changed?

This just adds docker.io to existing modules. Every module is specified with a full URI now.
If you know of any more let me know and I'll update.

Oh, yeah, so full retro-compatibility should be fairly possible

47 now!

mirpedrol
mirpedrol approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

modules/nf-core/universc/README.md Outdated Show resolved Hide resolved
@adamrtalbot adamrtalbot mentioned this pull request Apr 28, 2023
Merged
10 tasks
@pinin4fjords pinin4fjords mentioned this pull request Apr 28, 2023
Merged
9 tasks
@jasmezz jasmezz mentioned this pull request May 2, 2023
Merged
@adamrtalbot adamrtalbot mentioned this pull request May 2, 2023
Merged
4 tasks
@adamrtalbot adamrtalbot added this pull request to the merge queue May 2, 2023
Merged via the queue into nf-core:master with commit b9829e1 May 2, 2023
@adamrtalbot adamrtalbot deleted the default_registry_to_quay.io branch May 2, 2023 10:01
@ewels ewels mentioned this pull request May 2, 2023
Closed
14 tasks
jvfe added a commit to jvfe/modules that referenced this pull request May 2, 2023
@jvfe
Merge branch 'master' into islandpath
95cb7c8 
* master: (97 commits)
  Use long form docker.io address for Ubuntu (nf-core#3358)
  Default registry to quay.io (nf-core#3344)
  Sbwf impute glimpse2 (nf-core#3349)
  added cellranger vdj/mkvdjref modules, with module test for vdj (nf-core#3033)
  Add space to fix singularity download error on shinyngs modules (nf-core#3351)
  Output channel modification star (nf-core#3350)
  fix corrected typo in output (nf-core#3337)
  give execution permissions to dumpsoftwareversions.py (nf-core#3347)
  fix meta.ymls for dumpsoftware and multiqc (nf-core#3345)
  Fixing failing subworkflow tests (nf-core#3343)
  remove imputeme module since it is evidently no longer supported (nf-core#3223)
  Update path for yaml-schema json (nf-core#3340)
  New module MetaPhlAn4 (nf-core#3298)
  Update ALL bcftools modules (nf-core#3339)
  update docker and singularity version of p7zip (nf-core#3338)
  update sratools/fasterqdump to handle 10X data (nf-core#3336)
  Make MAD plots optional in shinyngs (nf-core#3334)
  reset tools in CI to released version (nf-core#3335)
  new module wisecondorx/gender (nf-core#3333)
  Bump shinyngs modules (nf-core#3323)
  ...
jvfe added a commit to jvfe/modules that referenced this pull request May 2, 2023
@jvfe
Merge branch 'master' into update-panaroo/run
0e077da 
* master: (120 commits)
  Use long form docker.io address for Ubuntu (nf-core#3358)
  Default registry to quay.io (nf-core#3344)
  Sbwf impute glimpse2 (nf-core#3349)
  added cellranger vdj/mkvdjref modules, with module test for vdj (nf-core#3033)
  Add space to fix singularity download error on shinyngs modules (nf-core#3351)
  Output channel modification star (nf-core#3350)
  fix corrected typo in output (nf-core#3337)
  give execution permissions to dumpsoftwareversions.py (nf-core#3347)
  fix meta.ymls for dumpsoftware and multiqc (nf-core#3345)
  Fixing failing subworkflow tests (nf-core#3343)
  remove imputeme module since it is evidently no longer supported (nf-core#3223)
  Update path for yaml-schema json (nf-core#3340)
  New module MetaPhlAn4 (nf-core#3298)
  Update ALL bcftools modules (nf-core#3339)
  update docker and singularity version of p7zip (nf-core#3338)
  update sratools/fasterqdump to handle 10X data (nf-core#3336)
  Make MAD plots optional in shinyngs (nf-core#3334)
  reset tools in CI to released version (nf-core#3335)
  new module wisecondorx/gender (nf-core#3333)
  Bump shinyngs modules (nf-core#3323)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels left review comments

@apeltzer apeltzer apeltzer left review comments

@JoseEspinosa JoseEspinosa JoseEspinosa left review comments

@maxulysse maxulysse maxulysse approved these changes

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@adamrtalbot @maxulysse @ewels @apeltzer @JoseEspinosa @mirpedrol @sateeshperi