Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template update for nf-core/tools v2.8 #124

Merged
merged 11 commits into from
May 1, 2023
Merged

Template update for nf-core/tools v2.8 #124

merged 11 commits into from
May 1, 2023

Conversation

pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented Apr 28, 2023 •
edited
Loading

Resolved conflicts for #121

Note: commented docker registry until the modules catch up in nf-core/modules#3344.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Apr 28, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 035a08f

+| ✅ 160 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-01 16:20:19

@pinin4fjords pinin4fjords changed the title Merging template updates Template update for nf-core/tools v2.8 Apr 28, 2023
jasmezz
jasmezz approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@jasmezz jasmezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/usage.md Outdated Show resolved Hide resolved
nextflow.config Show resolved Hide resolved
@jasmezz
Fix typo from template
035a08f 
Co-authored-by: Jasmin Frangenberg <73216762+jasmezz@users.noreply.github.com>
@pinin4fjords
Copy link
Member Author

Thanks for the review @jasmezz

@pinin4fjords pinin4fjords merged commit ebc90fc into nf-core:dev May 1, 2023
@pinin4fjords pinin4fjords deleted the merging-template-updates branch May 1, 2023 16:32
@pinin4fjords pinin4fjords added this to the 1.3.0 milestone May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasmezz jasmezz jasmezz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pinin4fjords @jasmezz @nf-core-bot