Scrubbing annotations from logs #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated scrubbing for guest side, and added scrubbing for annotations Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
anmaxvl
approved these changes
Mar 12, 2022
dcantah
reviewed
Mar 14, 2022
internal/guest/bridge/bridge.go
Outdated
| @@ -301,8 +301,19 @@ func (b *Bridge) ListenAndServe(bridgeIn io.ReadCloser, bridgeOut io.WriteCloser | |||
| trace.StringAttribute("activityID", base.ActivityID), | |||
| trace.StringAttribute("cid", base.ContainerID)) | |||
|
|
|||
| log.G(ctx).WithField("message", string(message)).Debug("request read message") | |||
|
|
|||
| etry := log.G(ctx) | |||
There was a problem hiding this comment.
Is this supposed to be entry?
There was a problem hiding this comment.
yeah, i forgot an n
dcantah
reviewed
Mar 14, 2022
internal/log/scrub.go
Outdated
| return nil | ||
| } | ||
| if ss, ok := m["ContainerConfig"]; ok { | ||
| // ContainerConfig is a json encoded struct passed as a regular sting field |
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
dcantah
approved these changes
Mar 14, 2022
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Updated scrubbing for guest side, and added scrubbing for annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated scrubbing to include logging from guest Linux GCS
Added scrubbing for annotations.
Signed-off-by: Hamza El-Saawy hamzaelsaawy@microsoft.com