Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix lint issue #1314

Merged
merged 1 commit into from
Mar 4, 2022
Merged

fix lint issue #1314

merged 1 commit into from
Mar 4, 2022

Conversation

anmaxvl
Copy link
Contributor

@anmaxvl anmaxvl commented Mar 4, 2022

Signed-off-by: Maksim An maksiman@microsoft.com

@anmaxvl
fix lint issue
359ca84 
Signed-off-by: Maksim An <maksiman@microsoft.com>
@anmaxvl anmaxvl requested a review from a team as a code owner March 4, 2022 00:39
@anmaxvl
Copy link
Contributor Author

anmaxvl commented Mar 4, 2022 •
edited
Loading

@dcantah PTAL 😄 all PRs are failing because of this, maybe we should just fix in a separate PR (this one).

@dcantah
Copy link
Contributor

dcantah commented Mar 4, 2022 •
edited
Loading

I'll try and look into why it seems like some make it through fine.. I'm trying to reason with how the actual pr that introduced this didn't run into anything. I'd even just rebased a previous pr on top of master (that has this change that it's whining about) and the linter didn't complain

@anmaxvl
Copy link
Contributor Author

anmaxvl commented Mar 4, 2022

so, it gets triggered on a branch in the main repo... like in the dependapot PR. but not caught on PRs from forks. maybe something wonky there.

dcantah
dcantah approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyways, lgtm

@anmaxvl anmaxvl merged commit 15d381c into microsoft:master Mar 4, 2022
@anmaxvl anmaxvl deleted the fix-lint-issue branch March 4, 2022 00:59
anmaxvl pushed a commit that referenced this pull request Feb 7, 2023
@ambarve
Merged PR 5895108: update ADO to d36cc7c
6a5be6f 
Related work items: #1240, #1241, #1258, #1260, #1270, #1271, #1272, #1279, #1286, #1288, #1289, #1292, #1293, #1294, #1295, #1297, #1298, #1299, #1301, #1305, #1307, #1308, #1309, #1310, #1313, #1314, #1315, #1318, #1320, #1321, #1322, #1324, #1326, #1328, #1332, #1333, #1334, #1335, #1337
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
@anmaxvl
fix lint issue (microsoft#1314)
d76cdb4 
Signed-off-by: Maksim An <maksiman@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcantah dcantah dcantah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anmaxvl @dcantah