Put Linux build tag on /internal/guest/transport/vsock.go #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the code in /internal/guest has build tags as it's all Linux specific so apply one for vsock.go as well as vsock.Dial is unimplemented on Windows. This also fixes a linter issue we've been seeing on the push trigger for golangci-lint. It complains that the error check we're performing can never be true (err == nil) because on linting this file with GOOS=windows it will check the Windows implementation for vsock.Dial which is hard coded to return an unimplemented error always. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
anmaxvl
approved these changes
Feb 18, 2022
katiewasnothere
approved these changes
Feb 18, 2022
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
…1301) Most of the code in /internal/guest has build tags as it's all Linux specific so apply one for vsock.go as well as vsock.Dial is unimplemented on Windows. This also fixes a linter issue we've been seeing on the push trigger for golangci-lint. It complains that the error check we're performing can never be true (err == nil) because on linting this file with GOOS=windows it will check the Windows implementation for vsock.Dial which is hard coded to return an unimplemented error always. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the code in /internal/guest has build tags as it's all Linux specific
so apply one for vsock.go as well as vsock.Dial is unimplemented on Windows.
This also fixes a linter issue we've been seeing on the push trigger for
golangci-lint. It complains that the error check we're performing can
never be true (err == nil) because on linting this file with GOOS=windows
it will check the Windows implementation for vsock.Dial which is hard coded
to return an unimplemented error.