Fallback to mavlink system ID if no UUID available #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the logic so that you the UUID is used if available but the mavlink system ID is used as a fallback option. The fallback happens if 3 requests for the autopilot_version are unsuccessful or if the AUTOPILOT_VERSION.uid field is 0.
There was a problem hiding this comment.
The code change looks reasonable but I don't think I can "approve" - my C++ isn't good enough.
That said, what I'm not seeing is:
- Update to docs explaining that UUID may not really be a UUID. This should probably be in:
device_uuids()andtypedef event_callback_t
|
Should the user be warned that they're working on a SYSID and not a real UUID? I guess the chances are that if the UUID < 255 they can tell that it is not "real". |
|
I added #81 for discussion of the cases that come up due to shared SYSID, and in particular when the UUID is the SYSID. |
Ok I'll add that to the docs, thanks @hamishwillee. |
This allows to direct the MAV_CMD_SET_MESSAGE_INTERVAL commands.
We use a timeout of 0.5s to slow the retries down. Otherwise, we can run into the case that the retries are exhausted just because many components send heartbeats at the same time, or if somebody sents heartbeats at a high(er) rate.
dlech
pushed a commit
to dlech/MAVSDK
that referenced
this pull request
Jan 14, 2022
mission: add missing result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the logic so that you the UUID is used if available but the
mavlink system ID is used as a fallback option. The fallback happens if
3 requests for the autopilot_version are unsuccessful or if the
AUTOPILOT_VERSION.uid field is 0.
This replaces #77.