Make the release action upload to real PyPI #70
Conversation
setup.py
Outdated
| @@ -1,6 +1,6 @@ | |||
| from setuptools import setup | |||
|
|
|||
| __version__ = "1.1.1-test" | |||
| __version__ = "1.1" | |||
There was a problem hiding this comment.
Shouldn't we follow semantic versioning like we do in other projects? In which case the version should be 1.1.0.
There was a problem hiding this comment.
Unless you're just testing stuff and I should just wait till it's up for review (github doesn't say a PR is a draft when sending a notification so I missed that status 😢 )
There was a problem hiding this comment.
1.1 already exists; it was chosen by the previous maintainer. I don't know if PyPI, pip etc consider 1.1 and 1.1.0 equivalent.
This change is intended to revert to the status quo after my testing on test.pypi.org. I'll can leave a comment encouraging a bump to 1.1.1 for the next version?
There was a problem hiding this comment.
Makes sense, and a comment sgtm
This reverts commit 9282e6f.
Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
Test was successful: see https://github.com/matrix-org/synapse-s3-storage-provider/runs/4312656424?check_suite_focus=true and https://test.pypi.org/project/synapse-s3-storage-provider/1.1.2/