Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the release action upload to real PyPI #70

Merged
merged 13 commits into from
Dec 1, 2021
Merged

Make the release action upload to real PyPI #70

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8e36bc8
Tweak version again
Nov 24, 2021
b19d70c
Maybe pypi will accept this number.
Nov 24, 2021
8ae8e56
I already tested uploading 1.1.1
Nov 24, 2021
3211f92
Make CI upload to real PyPI
Nov 25, 2021
8320a43
Back to 1.1.1
Nov 25, 2021
f89eec6
Revert back to 1.1
Nov 25, 2021
9b5974e
Comment re version number
Nov 25, 2021
19a3a93
Run `build` and `twine check` in regular CI
Nov 25, 2021
920ac58
Update readme
Nov 25, 2021
9282e6f
Amend readme with a note about m.org
Nov 25, 2021
44505ed
Revert "Amend readme with a note about m.org"
Nov 25, 2021
7b53772
Correctly link to workflow
Nov 25, 2021
fc045f2
clarify what kind of package we build
Nov 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
run: "python -m build"

- name: "Upload to PyPI"
run: "python -m twine upload --repository testpypi dist/*"
run: "python -m twine upload dist/*"
env:
TWINE_USERNAME: "__token__"
TWINE_PASSWORD: "${{ secrets.TESTPYPI_API_TOKEN }}"
TWINE_PASSWORD: "${{ secrets.PYPI_API_TOKEN }}"
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from setuptools import setup

__version__ = "1.1.1-test"
__version__ = "1.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we follow semantic versioning like we do in other projects? In which case the version should be 1.1.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you're just testing stuff and I should just wait till it's up for review (github doesn't say a PR is a draft when sending a notification so I missed that status 😢 )

Copy link
Contributor Author

@DMRobertson DMRobertson Nov 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.1 already exists; it was chosen by the previous maintainer. I don't know if PyPI, pip etc consider 1.1 and 1.1.0 equivalent.

This change is intended to revert to the status quo after my testing on test.pypi.org. I'll can leave a comment encouraging a bump to 1.1.1 for the next version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, and a comment sgtm


with open("README.md") as f:
long_description = f.read()
Expand Down