-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy GHA config for releasing to PyPI from s3 storage provider #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to update the release instructions in the templated README too?
We could do it as part of a different PR if you prefer.
|
||
- uses: "actions/setup-python@v2" | ||
with: | ||
python-version: "3.x" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the Python version matter here? I suppose not.
runs-on: "ubuntu-latest" | ||
steps: | ||
- uses: "actions/checkout@v2" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitty nit: We've got difference whitespace styles here and in ci.yml
. As a template I'd prefer it if we were consistent.
Thanks for taking a look Sean. On reflection I'm wondering if it might make more sense to define a |
This is matrix-org/backend-meta#4. |
matrix-org/synapse-s3-storage-provider#69 and matrix-org/synapse-s3-storage-provider#70 but for the generic template.
This will have the following effects:
PYPI_API_TOKEN
secret set and will fail otherwise.