Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sky spec #478

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Add Sky spec #478

merged 4 commits into from
Jan 8, 2024

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Jan 7, 2024

Launch Checklist

This is in continue to the following PR and relevant to the following issue:

It adds the relevant type, adds the validation, add the relevant tests and adds the updates the docs.
I have also made some small changes to the docs to improve maintainence.

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

image

@HarelM HarelM changed the title Sky spec Add Sky spec Jan 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86c4898) 92.09% compared to head (d680596) 92.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   92.09%   92.14%   +0.04%     
==========================================
  Files         100      101       +1     
  Lines        4176     4200      +24     
  Branches     1197     1201       +4     
==========================================
+ Hits         3846     3870      +24     
  Misses        330      330              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM merged commit 397b5e0 into main Jan 8, 2024
6 checks passed
@HarelM HarelM deleted the sky-spec branch January 8, 2024 21:44
@HarelM HarelM mentioned this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants