Style Spec for sky and fog #298
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
==========================================
- Coverage 77.83% 77.57% -0.26%
==========================================
Files 100 101 +1
Lines 4105 4129 +24
Branches 1176 1180 +4
==========================================
+ Hits 3195 3203 +8
- Misses 910 926 +16
☔ View full report in Codecov by Sentry. |
|
Can you please link to this PR in the following issue, and preferably comment on the suggestion there: |
|
Thinking about how best to test this. Do we have the ability to create a pre-release style spec package? There seems to be a lot of references to this package in maplibre-gl-js, I'm wondering if maybe making a pre-release with these changes would be easier than making my own package like I am trying now, since we could just change the version of style spec in package.json a lot easier. |
|
@drwestco I think you were able to do that, can you share your experience in a manual or a readme of some sort? |
|
I'm merging this into a local branch, I'll continue to work on it and create a PR that addresses my review comments. |
* Style Spec for sky and fog (#298) * Copy style-spec pieces from maplibre/maplibre-gl-js#1713 * add missing SkySpecification * fix lint error * Add tests, improve documentation, add to the style-spec docs * Fix lint * Update changelog --------- Co-authored-by: Andrew Calcutt <acalcutt@techidiots.net>
This is a attempt at bringing in the style spec code from maplibre/maplibre-gl-js#1713 into this new style-spec package. This is needed to implement sky and fog in maplibre-gl-js. Most of this code what pulled from the previous pr by @prozessor13 , but I've made a few tweaks where I saw it was needed.
I am mainly submitting this because I would like to see sky implemented and this seems like a good first step. This goes with maplibre/maplibre-gl-js#2974 , which I think still needs some work.