Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sky to diff #517

Closed
HarelM opened this issue Jan 31, 2024 · 0 comments · Fixed by #518
Closed

Add sky to diff #517

HarelM opened this issue Jan 31, 2024 · 0 comments · Fixed by #518
Labels
bug Something isn't working

Comments

@HarelM
Copy link
Collaborator

HarelM commented Jan 31, 2024

Describe the bug
When using diff after changing sky in the style, the diff command doesn't return anything.

To Reproduce
Steps to reproduce the behavior:

  1. Create a style
  2. add sky
  3. compare it to previous version
  4. See error

Expected behavior
There should be an opertaion to setSky in case the sky changed.

Additional context
This is related to #478 and also maplibre/maplibre-gl-js#3645
@HarelM HarelM added the bug Something isn't working label Jan 31, 2024
This was referenced Jan 31, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing sky in diff results maplibre/maplibre-style-spec
1 participant
@HarelM