Update fill-outline-color test expectations #5099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
They're not quite identical due to JS headless WebGL missing support for lines wider than 1px. #4601
kkaefer
force-pushed
the
fill-outline-rendering
branch
from
7523068
to
79e8574
Compare
jfirebaugh
reviewed
Aug 4, 2017
| @@ -9,7 +9,6 @@ | |||
| "render-tests/fill-extrusion-pattern/literal": "https://github.com/mapbox/mapbox-gl-js/issues/3327", | |||
| "render-tests/fill-extrusion-pattern/missing": "https://github.com/mapbox/mapbox-gl-js/issues/3327", | |||
| "render-tests/fill-extrusion-pattern/opacity": "https://github.com/mapbox/mapbox-gl-js/issues/3327", | |||
| "render-tests/fill-outline-color/fill": "https://github.com/mapbox/mapbox-gl-js/issues/4601", | |||
There was a problem hiding this comment.
fill-outline-color/fill isn't included in the image updates. Was it passing everywhere already?
jfirebaugh
approved these changes
Aug 4, 2017
There was a problem hiding this comment.
Looks like the gl-js output is still as described in #4601, but the differences are treated by pixelmatch as antialiasing differences and ignored. Seems ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mapbox/mapbox-gl-native#6927 mentions that these tests are different in JS vs. Native. Looking more at the code, I believe that the test expectations are wrong, and they should have the fuzzy antialiasing edges. JS headless doesn't have these due to #4601. However, when rendering these stylesheets in the browser, they do look like Native versions.