Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline drawing doesn't work in headless tests #4601

Closed
kkaefer opened this issue Apr 18, 2017 · 4 comments
Closed

Outline drawing doesn't work in headless tests #4601

kkaefer opened this issue Apr 18, 2017 · 4 comments

Comments

@kkaefer
Copy link
Contributor

kkaefer commented Apr 18, 2017

While investigating #4600, I discovered that drawing polygon outlines (antialiasing) isn't working correctly in headless tests. It does, however, work correctly when rendering in the browser.

Cf.:

JS headless:

unknown

Native headless:

unknown-1

This example is zoomed-fill/default from our render tests. Other examples in the render tests include tms/tms, extent/1024-fill, and any other tests that render fill polygons.

@kkaefer
Copy link
Contributor Author

kkaefer commented Apr 18, 2017

See mapbox/mapbox-gl-native#6927 (comment) for a possible cause.

@jfirebaugh
Copy link
Contributor

I think I saw it wasn't working 100% in the browser either -- it looked like glLineWidth didn't support any values other than 1.

http://webglstats.com/webgl/parameter/ALIASED_LINE_WIDTH_RANGE

@ansis
Copy link
Contributor

ansis commented May 8, 2017

ref #2080

I think I saw it wasn't working 100% in the browser either

Since I think ANGLE doesn't support anything > 1 I think it's broken on windows in firefox and chrome.

kkaefer added a commit that referenced this issue Aug 4, 2017
They're not quite identical due to JS headless WebGL missing support for lines wider than 1px.
#4601
kkaefer added a commit that referenced this issue Aug 4, 2017
They're not quite identical due to JS headless WebGL missing support for lines wider than 1px.
#4601
kkaefer added a commit that referenced this issue Aug 4, 2017
They're not quite identical due to JS headless WebGL missing support for lines wider than 1px.
#4601
kkaefer added a commit that referenced this issue Aug 7, 2017
They're not quite identical due to JS headless WebGL missing support for lines wider than 1px.
#4601
@jfirebaugh
Copy link
Contributor

Duplicate of #2080.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants