Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

fill-outline-color render tests failing locally on OS X #6927

Closed
jfirebaugh opened this issue Nov 4, 2016 · 3 comments
Closed

fill-outline-color render tests failing locally on OS X #6927

jfirebaugh opened this issue Nov 4, 2016 · 3 comments
Labels
Core The cross-platform C++ core, aka mbgl rendering tests

Comments

@jfirebaugh
Copy link
Contributor

The following render tests, which were unignored as part of #6899, are failing locally for me on OS X, although they are passing on OS X CI:

  • failed fill-outline-color function
  • failed fill-outline-color literal
  • failed fill-outline-color multiply
  • failed fill-outline-color opacity
  • failed regressions mapbox-gl-js#2305

Here's what the first one looks like:

Expected
image

Actual
image

Diff
image

The diff on macOS CI, where these are passing, is:
image

I'm currently at 6c30105 and mapbox/mapbox-gl-test-suite@d27aab1, macOS 10.11.6 (15G1108).

@jfirebaugh
Copy link
Contributor Author

At least part of the difference seems to be due to the following:

  • Mapbox GL JS renders both fill outline (when fill-outline-color is set) and fill antialias (when it isn't) after the fill.
  • Mapbox GL Native renders fill outline before the fill, or fill antialias after.

When I change native to work like js does, it reduces the difference to:

image

But the corners are still off.

@jfirebaugh
Copy link
Contributor Author

The remaining difference is due to glLineWidths other than 1 not being supported by the headless rendering in GL-JS test environment.

@kkaefer
Copy link
Contributor

kkaefer commented Aug 7, 2017

Fixed in #9699

@kkaefer kkaefer closed this as completed Aug 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl rendering tests
Projects
None yet
Development

No branches or pull requests

2 participants