Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Update mr-ui and npm audit #266

Merged
merged 8 commits into from
May 14, 2020
Merged

Update mr-ui and npm audit #266

merged 8 commits into from
May 14, 2020

Conversation

katydecorah
Copy link
Contributor

@katydecorah katydecorah commented Apr 1, 2020

This PR update mr-ui to the latest so we can get the fix for the CopyButton (which is used in our version of CodeSnippet).

Fixes #270

How to test

QA checklist

  • No errors logged to console.
  • Accessibility score in Chrome DevTools Audit/Lighthouse is 100% with Lighthouse version: #.#.#.
  • Component is accessible at mobile-size viewport.
  • Component is accessible at tablet-size viewport.
  • Component is accessible at laptop-size viewport.
  • Component is accessible at big-monitor-size viewport.
  • Create a PR in a site repo, copy the component, and test it. Push to staging and let the reviewer know they can also test the component there.

Open the test cases app locally on:

  • Chrome, no errors logged to console.
  • Firefox, no errors logged to console.
  • Safari, no errors logged to console.
  • Edge, no errors logged to console.
  • IE11, no errors logged to console.
  • Mobile Safari, no errors logged to console.
  • Android Chrome, no errors logged to console.

@katydecorah katydecorah added this to the 0.28.0 milestone Apr 28, 2020
@colleenmcginnis colleenmcginnis mentioned this pull request Apr 28, 2020
14 tasks
* master:
  Add `Topbar` component (#274)
  Fix bug in NumberedCodeSnippet (#268)
  Update issue templates
@katydecorah katydecorah merged commit a811dde into master May 14, 2020
@katydecorah katydecorah deleted the update-mr-ui branch May 14, 2020 20:05
katydecorah pushed a commit that referenced this pull request May 14, 2020
* master:
  Update mr-ui and npm audit (#266)
katydecorah pushed a commit that referenced this pull request Jun 9, 2020
* master: (50 commits)
  0.29.1
  Update CHANGELOG.md
  Remove `limiter` from Topbar (#282)
  0.29.0
  Prepare 0.29.0
  Allow Kotlin-only activities (#278)
  0.28.0
  Prepare 0.28.0
  Prevent `ProductMenu` from truncating `tag` (#277)
  Update mr-ui and npm audit (#266)
  Add `Topbar` component (#274)
  Fix bug in NumberedCodeSnippet (#268)
  Update issue templates
  Fix padding and background on NumberedCodeSnippet (#269)
  Prepare 0.27.0
  Update Sentry
  Send basic user metadata along with Feedback (#255)
  Set character limit for `Feedback` texteara (#244)
  Add tests to assert Segment event in Feedback component (#256)
  Add `icon` option for third level items in NavigationAccordion (#252)
  ...
katydecorah pushed a commit that referenced this pull request Jun 25, 2020
* master:
  0.29.1
  Update CHANGELOG.md
  Remove `limiter` from Topbar (#282)
  0.29.0
  Prepare 0.29.0
  Allow Kotlin-only activities (#278)
  0.28.0
  Prepare 0.28.0
  Prevent `ProductMenu` from truncating `tag` (#277)
  Update mr-ui and npm audit (#266)
  Add `Topbar` component (#274)
  Fix bug in NumberedCodeSnippet (#268)
  Update issue templates
katydecorah pushed a commit that referenced this pull request Jun 25, 2020
* master:
  0.29.1
  Update CHANGELOG.md
  Remove `limiter` from Topbar (#282)
  0.29.0
  Prepare 0.29.0
  Allow Kotlin-only activities (#278)
  0.28.0
  Prepare 0.28.0
  Prevent `ProductMenu` from truncating `tag` (#277)
  Update mr-ui and npm audit (#266)
  Add `Topbar` component (#274)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buttons do not have an accessible name
1 participant