Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple Mint v2 #5939

Closed
EthVlad opened this issue May 12, 2023 · 16 comments · Fixed by #7208
Closed

Simple Mint v2 #5939

EthVlad opened this issue May 12, 2023 · 16 comments · Fixed by #7208
Labels
$$ ~51-150usd A-minting related to minting operations A-nuxt A-statemine-ahk related for statemine common chain, under new name Asset Hub Kusama A-statemint-ahp Polkadot Asset Hub related issues A-vue3 good first issue as new commer, something you could start with p2 core functionality, or is affecting 60% of app Ready for dev

Comments

@EthVlad
Copy link

EthVlad commented May 12, 2023

All of the designs for desktop, mobile and dark mode are ready here:

Static designs: https://www.figma.com/file/JXNtryaNYhY0XJNArzvPQx/Handoff?node-id=142-1572
Prototype: https://www.figma.com/file/JXNtryaNYhY0XJNArzvPQx/Handoff?node-id=142-3057&t=VTvnGZy65YppHmE2-4

Need to only revise some small details (tags, toggles and 1 title) - note for me.

Moved from

@EthVlad EthVlad added p2 core functionality, or is affecting 60% of app A-minting related to minting operations labels May 12, 2023
@yangwao yangwao added the $$ ~51-150usd label Jun 5, 2023
@yangwao yangwao added the good first issue as new commer, something you could start with label Aug 8, 2023
@yangwao
Copy link
Member

yangwao commented Aug 8, 2023

Hey @kodadot/internal-dev if someone want to pick this up :)
Best rework it in Vue3 for Nuxt3

@god-of-js
Copy link
Contributor

Is this still available?
👋

@exezbcz
Copy link
Member

exezbcz commented Aug 10, 2023

@god-of-js afaik it is

@vikiival
Copy link
Member

Just few things to mention:

  1. First Editions are confusing words for both devs and users,
    Therefore we call it copies
editions
  1. this is a logical error (cc @EthVlad)

Since you are selecting collection for minting, you cannot select blockchain for it as it is tied to collection.

If it was intended as simple mint you should either select blockchain or collection

select-block

@yangwao
Copy link
Member

yangwao commented Aug 10, 2023

@god-of-js if you could deliver it (merged) end of week there is extra $100 for you, with reasonable code quality ofc!

@yangwao yangwao added A-statemine-ahk related for statemine common chain, under new name Asset Hub Kusama A-statemint-ahp Polkadot Asset Hub related issues labels Aug 10, 2023
@god-of-js
Copy link
Contributor

👋

@kodabot
Copy link
Collaborator

kodabot commented Aug 11, 2023

ASSIGNED - @god-of-js 🔒 LOCKED -> Monday, August 14th 2023, 13:01:53 UTC -> 72 hours

@yangwao
Copy link
Member

yangwao commented Aug 13, 2023

@god-of-js do you plan to raise PR today?

@god-of-js
Copy link
Contributor

@god-of-js do you plan to raise PR today?

Yes, please. expect my PR in the evening.

@god-of-js
Copy link
Contributor

Hey guys, really sorry for the inconvenience, something came up and I may not be able to complete it by the deadline.
I would unassign myself so someone else can pick it up.
I would pick up another task when I'm back.
Once again, I am really sorry for the inconvenience.

@god-of-js god-of-js removed their assignment Aug 13, 2023
@kodabot
Copy link
Collaborator

kodabot commented Aug 13, 2023

ASSIGNMENT OVER - @god-of-js has been unassigned.

@EthVlad
Copy link
Author

EthVlad commented Aug 14, 2023

First Editions are confusing words for both devs and users,
Therefore we call it copies

ok

This is a logical error (cc @EthVlad)
Since you are selecting a collection for minting, you cannot choose blockchain as it is tied to a collection.
If it was intended as simple mint you should either select blockchain or collection

in that case, we could simply just grey out the blockchain field once a specific collection is selected and vice-versa
when blockchain is selected display only collections from that blockchain in the dropdown menu.
This way user can choose either collection or blockchain to where he wants to mint.

@preschian
Copy link
Member

👋

let me try

@preschian
Copy link
Member

preschian commented Aug 26, 2023

I'm planning to create two branches for this

  1. Unify create collection - refactor: unify create collection #6974
  2. Unify create nft - to do

Adjustment

hi @EthVlad @exezbcz

  1. Is it okay to put "select blockchain" at first? I'm planning to put that also on the create NFT page. "select blockchain" -> "select collection" -> "rest of the fields"
  2. Currently our library component doesn't support putting image + text under select elements. so I'm using the Dropdown component to do that. is that ok?

image

Follow-up issues

  • Collection - Banner Images
  • Collection - Category and Tags
  • Collection - Explicit Content

@exezbcz
Copy link
Member

exezbcz commented Aug 27, 2023

Is it okay to put "select blockchain" at first? I'm planning to put that also on the create NFT page. "select blockchain" -> "select collection" -> "rest of the fields"

I would not change the collection order, tho as starting with uploading images is IMO better than selecting blockchain. For creating nft, I am okay with the change as it makes more sense first to select blockchain. Or do this:

as Vlad clarified:

in that case, we could simply just grey out the blockchain field once a specific collection is selected and vice-versa
when blockchain is selected display only collections from that blockchain in the dropdown menu.
This way user can choose either collection or blockchain to where he wants to mint.

Currently our library component doesn't support putting image + text under select elements. so I'm using the Dropdown component to do that. is that ok?

hmm, I still prefer having the grey stroke style since the whole container that the design is wrapped in has drop shadow, double drop shadow is not good. Could you change the colors there, if not possible, I think matching the style is more important than displaying network images

@preschian
Copy link
Member

I would not change the collection order
I think matching the style is more important than displaying network images

noted, will update that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$$ ~51-150usd A-minting related to minting operations A-nuxt A-statemine-ahk related for statemine common chain, under new name Asset Hub Kusama A-statemint-ahp Polkadot Asset Hub related issues A-vue3 good first issue as new commer, something you could start with p2 core functionality, or is affecting 60% of app Ready for dev
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

7 participants