Move Condition stuff to apis, add a v1beta1 Status. #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
approved
knative-prow-robot
requested review from
evankanderson,
mdemirhan,
n3wscott,
tcnghia and
vaikas
|
/hold Putting a hold on this, but I'd like to land it once we cut 0.5 |
knative-prow-robot
added
the
do-not-merge/hold
|
You can see my WIP import into serving here, although I'll probably split it across a few PRs. |
|
I'll fix coverage too :( |
mattmoor
force-pushed
the
cond-v1beta1
branch
3 times, most recently
from
588cba1
to
7947aaf
Compare
|
This needs: #358 UPDATE: pushing the above out, we're not ready for it in serving. :( |
This moves the common Condition stuff to apis, and creates a v1beta1 form of Status that uses the Condition it defines (changing this in v1alpha1 is too breaking). There aren't really any meaningful changes in this PR, mostly reorganization. Enumerating what I did: 1. Copied `condition_set*.go` to `apis/`, 1. Copied the `Condition` portions of `conditions_types.go` to `apis/`, 1. Copied the balance of `conditions_types.go` to `apis/duck/v1beta1/status_types.go`, 1. Changed the parts of the above to reference things in the appropriate new places, 1. Removed the reflection-based `ConditionsAccessor` stuff, implementing it instead on `duckv1beta1.Status`. 1. Incorporate: knative#358
|
The following is the coverage report on pkg/.
|
|
/hold cancel This creates a second parallel implementation, so it won't disrupt anyone if it goes in early. |
knative-prow-robot
removed
the
do-not-merge/hold
mattmoor
added a commit
to mattmoor/build
that referenced
this pull request
Apr 2, 2019
See here for more context on what's changed (no breaking changes): knative/pkg#361
mattmoor
added a commit
to mattmoor/build
that referenced
this pull request
Apr 2, 2019
See here for more context on what's changed (no breaking changes): knative/pkg#361
|
/lgtm |
mattmoor
added a commit
to mattmoor/build
that referenced
this pull request
Apr 2, 2019
See here for more context on what's changed (no breaking changes): knative/pkg#361
mattmoor
added a commit
to mattmoor/build
that referenced
this pull request
Apr 4, 2019
See here for more context on what's changed (no breaking changes): knative/pkg#361
mattmoor
added a commit
to mattmoor/build
that referenced
this pull request
Apr 4, 2019
See here for more context on what's changed (no breaking changes): knative/pkg#361
vdemeester
added a commit
to vdemeester/tektoncd-pipeline
that referenced
this pull request
Apr 9, 2019
See here for more context on what's changed (no breaking changes): knative/pkg#361 Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
1 task
vdemeester
added a commit
to vdemeester/tektoncd-pipeline
that referenced
this pull request
Apr 10, 2019
See here for more context on what's changed (no breaking changes): knative/pkg#361 Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
vdemeester
added a commit
to vdemeester/tektoncd-pipeline
that referenced
this pull request
Apr 10, 2019
See here for more context on what's changed (no breaking changes): knative/pkg#361 Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
vdemeester
added a commit
to vdemeester/tektoncd-pipeline
that referenced
this pull request
Apr 16, 2019
See here for more context on what's changed (no breaking changes): knative/pkg#361 Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
tekton-robot
pushed a commit
to tektoncd/pipeline
that referenced
this pull request
Apr 17, 2019
See here for more context on what's changed (no breaking changes): knative/pkg#361 Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the common Condition stuff to apis, and creates a v1beta1 form of Status that uses the Condition it defines (changing this in v1alpha1 is too breaking).
There aren't really any meaningful changes in this PR, mostly reorganization. Enumerating what I did:
condition_set*.gotoapis/,Conditionportions ofconditions_types.gotoapis/,conditions_types.gotoapis/duck/v1beta1/status_types.go,ConditionsAccessorstuff, implementing it instead onduckv1beta1.Status.cc @vdemeester (since you commented on the predecessors)
FYI I was able to import this into serving without any code changes, then lots to take advantage of it.