Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update networking types to duckv1beta1.Status #3614

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Update networking types to duckv1beta1.Status #3614

merged 2 commits into from
Apr 2, 2019

Conversation

mattmoor
Copy link
Member

@mattmoor mattmoor commented Apr 2, 2019

For more information see: knative/pkg#361

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 2, 2019
@knative-prow-robot knative-prow-robot added area/API API objects and controllers area/networking size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 2, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2019
@mattmoor mattmoor changed the title [WIP] Update networking types to duckv1beta1.Status Update networking types to duckv1beta1.Status Apr 2, 2019
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2019
@tcnghia
Copy link
Contributor

tcnghia commented Apr 2, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2019
@mattmoor mattmoor closed this Apr 2, 2019
@mattmoor mattmoor reopened this Apr 2, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/networking/v1alpha1/certificate_lifecycle.go Do not exist 100.0%
pkg/apis/networking/v1alpha1/clusteringress_lifecycle.go Do not exist 100.0%
pkg/apis/networking/v1alpha1/serverlessservice_lifecycle.go Do not exist 100.0%
pkg/apis/serving/v1alpha1/route_lifecycle.go Do not exist 100.0%
pkg/reconciler/v1alpha1/clusteringress/clusteringress.go 78.6% 80.8% 2.2

@knative-prow-robot knative-prow-robot merged commit 7547276 into knative:master Apr 2, 2019
@mattmoor mattmoor deleted the networking-beta-status branch April 2, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso Awaiting requested review from dprotaso

@mdemirhan mdemirhan Awaiting requested review from mdemirhan

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@tcnghia tcnghia

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattmoor @knative-prow-robot @tcnghia @knative-metrics-robot @googlebot