Skip to content
This repository has been archived by the owner on Sep 5, 2019. It is now read-only.

Move to the v1beta1 Conditions implementation. #590

Closed
wants to merge 1 commit into from

Conversation

mattmoor
Copy link
Member

@mattmoor mattmoor commented Apr 2, 2019

See here for more context on what's changed (no breaking changes): knative/pkg#361

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattmoor mattmoor force-pushed the v1beta1-conditions branch 3 times, most recently from e5ec36e to ac3f8ca Compare April 4, 2019 14:15
@mattmoor mattmoor changed the title [WIP] Move to the v1beta1 Conditions implementation. Move to the v1beta1 Conditions implementation. Apr 4, 2019
See here for more context on what's changed (no breaking changes): knative/pkg#361
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-build-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/build/build.go 69.5% 68.8% -0.8

@mattmoor
Copy link
Member Author

mattmoor commented Apr 7, 2019

/retest

@imjasonh
Copy link
Member

imjasonh commented Apr 8, 2019

/test pull-knative-build-integration-tests

@knative-prow-robot
Copy link

@mattmoor: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-build-integration-tests b720948 link /test pull-knative-build-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vdemeester
Copy link
Member

@mattmoor knative/pkg now uses apps instead of extensions for Deployment (see knative/pkg@8b3dc0d). Might be why the e2e fails

@mattmoor mattmoor closed this May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants