Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Selenium Grid scaler #6169

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor Selenium Grid scaler #6169

wants to merge 1 commit into from

Conversation

VietND96
Copy link

@VietND96 VietND96 commented Sep 17, 2024

Provide a description of what has been changed

  1. Selenium Grid Scaler: Improve logic based on node stereotypes, node sessions and queue requests capabilities (#6080)
  • Enhanced KEDA scaler behavior, addressing:
    • Node with different platformName scaling: Fixed incorrect scaling behavior when both Linux and Windows node stereotypes are present (#1925).
    • Excessive autoscaling: Resolved over-scaling of browser nodes (#2160).
  1. Added one more parameter nodeMaxSessions (default is 1), to configure the scaler to be aligned with option --max-sessions (env var SE_NODE_MAX_SESSIONS) in the Node. It helps the calculation be better.
  2. Selenium Grid Scaler: Support for Username and Password Authentication of Grid GraphQL endpoint (#6144)
  3. Update all unit tests accordingly to the new GraphQL response.

Checklist

Fixes #6144 Fixes #6080

Relates to SeleniumHQ/docker-selenium#2160, SeleniumHQ/docker-selenium#1925, #6047

@SpiritZhou
Copy link
Contributor

SpiritZhou commented Sep 18, 2024

/run-e2e selenium
Update: You can check the progress here

@VietND96
Copy link
Author

VietND96 commented Oct 2, 2024

Noted that we also set up some e2e tests in the downstream repo https://github.com/SeleniumHQ/docker-selenium/tree/trunk/.keda for the evaluation and feedback from community

@zroubalik
Copy link
Member

zroubalik commented Oct 2, 2024

/run-e2e selenium
Update: You can check the progress here

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is really great, thanks for the contribution!

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants