Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Selenium Grid scaler #1468

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

VietND96
Copy link

Provide a description of what has been changed

An update for kedacore/keda#6169 will come in the upcoming release v2.16.
@SeleniumHQ involve as long term maintainer for the scaler

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@VietND96 VietND96 requested a review from a team as a code owner September 17, 2024 11:38
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit fbec421
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/66ec04fcbc19910008ec8d75
😎 Deploy Preview https://deploy-preview-1468--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SeleniumHQ involve as maintainer

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@VietND96 VietND96 changed the title Update for Selenium Grid scaler in release 2.16 Update for Selenium Grid scaler Sep 23, 2024
Comment on lines +33 to +34
- `username` - Username for basic authentication in GraphQL endpoint instead of embedding in the URL. (Optional)
- `password` - Password for basic authentication in GraphQL endpoint instead of embedding in the URL. (Optional)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's decide on this in the code first: kedacore/keda#6169 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants