-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sessionsPerNode and setSessionsFromHub parameters to selenium-grid scaler #6055
base: main
Are you sure you want to change the base?
add sessionsPerNode and setSessionsFromHub parameters to selenium-grid scaler #6055
Conversation
Could you open an issue and provide a description of your improvement for better tracking? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good ❤️ @Wolfe1 WDYT?
/run-e2e selenium |
@rubroboletus , there are 2 checks failing:
Could you take a look please? |
…d scaler, add tests and changelog Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz>
Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz>
Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz>
Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz>
Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz>
Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz>
Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Robert Hanzlík <robi@junyks.cz> Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz>
55c5325
to
4e22dea
Compare
Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz>
@JorTurFer Fixed. |
/run-e2e selenium |
@rubroboletus, can you review this PR #6169 to see it can solve your expectation. |
Problem is, that you can obtain info from the Grid only in case, that there is at least one node of such type running. When there is no node of such type running, you know nothing about its settings. |
Ok, I can understand now, the problem for calculation when minReplica=0. |
I updated one more scaler param |
Added two new parameters for selenium-grid scaler, allowing to scale up based on real browser node sizing. When sesSessionsFromHub is set, KEDA will look for existing browser nodes with browserName, browserVersion and platformName same as scaledObject / scaledJob, get maxSessions and calculate how much nodes it needs. When no existing browser node matches, it uses sessionsPerNode value for calculation.
Checklist
Fixes #
Relates to #