[JENKINS-58069] Add a hook for JCasC Plugin to enable PCT runs with it #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
approved these changes
Jun 20, 2019
There was a problem hiding this comment.
LGTM. After the PR is integrated, we will need to add support of Maven caches like in #156 . Will do in downstream so that we have less merge conflicts
added 6 commits
June 20, 2019 12:29
|
Given #160 already had the approvals and CI is already passing, I'm merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same than #160 but now with write permissions so changes in Jenkinsfile should be taken by the PR builder.