Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-58069] Add a hook for JCasC Plugin to enable PCT runs with it #160

Closed
wants to merge 4 commits into from

Conversation

varyvol
Copy link

@varyvol varyvol commented Jun 18, 2019

JENKINS-58069

Create a multimodule hook for the configuration-as-code plugin.

Screen Shot 2019-06-18 at 13 02 56

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does it execute https://github.com/jenkinsci/configuration-as-code-plugin/tree/master/integrations after the patch? If not, we should think how to get it added, because the majority of tests are there

@batmat
Copy link
Member

batmat commented Jun 18, 2019

I think there should really be an added IT inside the Jenkinsfile showing JCasC does work with this. At least as a test PR on top of this one. AFAIR, we have spent a lot of time on PCT regressions, and had decided to be more picky with IT?

@varyvol
Copy link
Author

varyvol commented Jun 19, 2019

@batmat added though I lack permissions for the Jenkinsfile to be integrated :(

@oleg-nenashev oleg-nenashev changed the title [JENKINS-58069] CasC is a multimodule project so add the proper hook. [JENKINS-58069] Add a hook for JCasC Plugin to enable PCT runs with it Jun 20, 2019
@varyvol varyvol closed this Jun 20, 2019
@varyvol varyvol reopened this Jun 20, 2019
@varyvol
Copy link
Author

varyvol commented Jun 21, 2019

Continued under #166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants