[JENKINS-57935] - Always poll the Update Center for plugin Group IDs when building WARs with plugins #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when buildin WARs with plugins
raul-arabaolaza
approved these changes
Jun 10, 2019
batmat
previously requested changes
Jun 10, 2019
|
@batmat creation of the integration test requires a Custom WAR to be produced and included into the test. So far we do not have any official distributions for such custom WARs in the Jenkins community, and it would be a significant task to create one. Although I agree with having integration tests, I suggest detaching it to a separate task |
MRamonLeon
approved these changes
Jun 10, 2019
On-demand plugin installation tests are fun |
|
Uh oh. Will investigate. This is exactly what I was fixing (and it worked on my machine) |
Actually build a custom Docker image during the build
|
Now it somehow starts with old plugins, CWP does not trace it on its own (known issue) |
|
WithPlugin tests are killing me |
|
In the test... Something went wrong, not sure what |
Any ideas why it could happen @raul-arabaolaza . It there any code which may downgrade a version from the bundle? |
|
Closing in favor of #169 |
jglick
added a commit
to jglick/plugin-compat-tester
that referenced
this pull request
Feb 24, 2020
raul-arabaolaza
pushed a commit
that referenced
this pull request
Apr 13, 2020
Revert #156 as it makes PCT sensitive to UC; instead pass groupId: in -overridenPlugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.jenkins-ci.org/browse/JENKINS-57935 . Before the fix PCT was not trying to resolve Group IDs from the update center when there were bundled plugins. It is critical for some optional dependencies which are not usually bundled.
The change should cause no regressions, because groupIDs from WAR will be still a priority