This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
JobPropertyStep #209
Merged
JobPropertyStep #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
Conflicts: multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/JobPropertyStepTest.java
…sDefinitionProperty.
Without JENKINS-27295, this makes it awkward to have a default parameter value.
| @Extension public static class HideSuperfluousBranchProperties extends DescriptorVisibilityFilter { | ||
|
|
||
| @Override public boolean filter(Object context, Descriptor descriptor) { | ||
| if (context instanceof WorkflowMultiBranchProject && (descriptor.clazz == RateLimitBranchProperty.class || descriptor.clazz == BuildRetentionBranchProperty.class)) { |
There was a problem hiding this comment.
It seems hacky? If another property like RateLimitBranchProperty is added for some reason, it should be excluded here too. Is not there another way to exclude them?
There was a problem hiding this comment.
We want to include unknown branch properties by default. There is no way that I can think of to mechanically determine whether they are simply wrappers for job properties.
jglick
added a commit
to jglick/workflow-multibranch-plugin
that referenced
this pull request
May 25, 2016
…to reproduce JENKINS-30206.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-30519
JobPropertyStepDescribableHelper@DataBoundConstructoronParametersDefinitionPropertyJobProperty/config.jellyfix JENKINS-29711 problem in(leave it for another day)SnippetizerWorkflowParameterDefinitionBranchPropertybuildDiscardertriggersquietPeriodconcurrentBuildauthTokenRateLimitBranchPropertytest against Let GithubProjectProperty be applied to any Job github-plugin#84 when released(have tested against snapshots)OptionalJobPropertyupstream: JobPropertyStep with OptionalJobProperty & fixed ParametersDefinitionProperty #228BuildDiscarderPropertyupstream: JobPropertyStep with OptionalJobProperty & fixed ParametersDefinitionProperty & BuildDiscarderProperty #229@reviewbybees esp. @kohsuke & @stephenc